search

desbma / sacad

Smart Automatic Cover Art Downloader
Mozilla Public License 2.0
320 stars 17 forks source link

asyncio: Unclosed client session #19

Closed RealPiHalbe closed 6 years ago

RealPiHalbe commented 6 years ago

I am very happy to have found this tool. Unfortunately, after finding correct cover art, it will not save the file. There seems to be a problem with asyncio. I am using Python 3.5.2 with sacad-2.0.6.

myshell$ /home/me/.local/bin/sacad "metallica" "master of puppets" 600 AlbumArt.jpg
Main: jpegoptim could not be found, JPEG crunching will be disabled
Main: optipng could not be found, PNG crunching will be disabled
GoogleImagesWebScrapeCoverSource: Got 9 relevant (11 excluded) results from source 'GoogleImagesWebScrapeCoverSource'
LastFmCoverSource: Got 0 relevant (5 excluded) results from source 'LastFmCoverSource'
AmazonCdCoverSource: Got 10 relevant (1 excluded) results from source 'AmazonCdCoverSource'
AmazonDigitalCoverSource: Got 5 relevant (0 excluded) results from source 'AmazonDigitalCoverSource'
Cover: Removed 1 duplicate results
Cover: Reference is: LastFmCoverSourceResult 'https://lastfm-img2.akamaized.net/i/u/300x300/07f492a00c904cc6ccf868010be4d5a6.png'
Cover: Downloading cover 'https://images-na.ssl-images-amazon.com/images/I/810AxLh7%2BQL._SL1425_.jpg' (part 1/1)...
Cover: Resizing from 1425x1425 to 600x600...
/home/me/.local/lib/python3.5/site-packages/sacad/http_helpers.py:39: RuntimeWarning: coroutine 'ClientSession.close' was never awaited
  self.session.close()  # silences a warning on shutdown
asyncio: Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7f03da4ca080>
asyncio: Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7f03da4d03c8>
asyncio: Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7f03da4d05f8>
asyncio: Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7f03da4d01d0>
myshell$

Anything I did wrong or is this a problem that can occur under regular usage?

jackalblood commented 6 years ago

It seems i also have the same issue

2018-03-18 22:08:53,864 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1835d240> 2018-03-18 22:08:53,864 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1835d780> 2018-03-18 22:08:53,864 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1835dda0> 2018-03-18 22:08:53,864 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1835dbe0> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1835da58> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1835df98> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183645f8> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18364438> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183642b0> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183647f0> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18364e10> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18364c50> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18364ac8> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18368048> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18368668> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183684a8> 2018-03-18 22:08:53,865 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18368320> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18368860> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18368e80> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18368cc0> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18368b38> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f00b8> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f06d8> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f0518> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f0390> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f08d0> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f0ef0> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f0d30> 2018-03-18 22:08:53,866 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f0ba8> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f7128> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f7748> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f7588> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f7400> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f7940> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f7f60> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f7da0> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182f7c18> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182fd198> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182fd7b8> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182fd5f8> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182fd470> 2018-03-18 22:08:53,867 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182fd9b0> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182fdfd0> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182fde10> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182fdc88> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18303208> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18303828> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18303668> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183034e0> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18303a20> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18309080> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18303e80> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18303cf8> 2018-03-18 22:08:53,868 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18309278> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18309898> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183096d8> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18309550> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18309a90> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183110f0> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18309ef0> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18309d68> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183112e8> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18311908> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18311748> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183115c0> 2018-03-18 22:08:53,869 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18311b00> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18318160> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18311f60> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18311dd8> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18318358> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18318978> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca183187b8> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18318630> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18318b70> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1831d1d0> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18318fd0> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18318e48> 2018-03-18 22:08:53,870 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1831d3c8> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1831d9e8> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1831d828> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1831d6a0> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1831dbe0> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18322240> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18322080> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1831deb8> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18322438> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18322a58> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18322898> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18322710> 2018-03-18 22:08:53,871 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18322c50> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182ab2b0> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182ab0f0> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18322f28> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182ab4a8> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182abac8> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182ab908> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182ab780> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182abcc0> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b2320> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b2160> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182abf98> 2018-03-18 22:08:53,872 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b2518> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b2b38> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b2978> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b27f0> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b2d30> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b9390> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b91d0> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b9048> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b9588> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b9ba8> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b99e8> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b9860> 2018-03-18 22:08:53,873 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182b9da0> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182be400> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182be240> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182be0b8> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182be5f8> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182bec18> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182bea58> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182be8d0> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182bee10> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182c3470> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182c32b0> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182c3128> 2018-03-18 22:08:53,874 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182c3668> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182c3c88> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182c3ac8> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182c3940> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182c3e80> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182cb4e0> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182cb320> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182cb198> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182cb6d8> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182cbcf8> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182cbb38> 2018-03-18 22:08:53,875 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182cb9b0> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182cbef0> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d2550> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d2390> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d2208> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d2748> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d2d68> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d2ba8> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d2a20> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d2f60> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d75c0> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d7400> 2018-03-18 22:08:53,876 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d7278> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d77b8> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d7dd8> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d7c18> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d7a90> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182d7fd0> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182dc630> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182dc470> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182dc2e8> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182dc828> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182dce48> 2018-03-18 22:08:53,877 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182dcc88> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182dcb00> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182e5080> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182e56a0> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182e54e0> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182e5358> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182e5898> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182e5eb8> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182e5cf8> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182e5b70> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1826c0f0> 2018-03-18 22:08:53,878 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1826c710> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1826c550> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1826c3c8> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1826c908> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1826cf28> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1826cd68> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1826cbe0> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18271160> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18271780> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182715c0> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18271438> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18271978> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18271f98> 2018-03-18 22:08:53,879 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18271dd8> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18271c50> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182791d0> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182797f0> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18279630> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182794a8> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182799e8> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1827f048> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18279e48> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18279cc0> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1827f240> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1827f860> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1827f6a0> 2018-03-18 22:08:53,880 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1827f518> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1827fa58> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182860b8> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1827feb8> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1827fd30> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182862b0> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182868d0> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18286710> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18286588> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18286ac8> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1828d128> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18286f28> 2018-03-18 22:08:53,881 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18286da0> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1828d320> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1828d940> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1828d780> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1828d5f8> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1828db38> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18292198> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1828df98> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1828de10> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18292390> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182929b0> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182927f0> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18292668> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18292ba8> 2018-03-18 22:08:53,882 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1829b208> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1829b048> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca18292e80> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1829b400> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1829ba20> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1829b860> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1829b6d8> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1829bc18> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a1278> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a10b8> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca1829bef0> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a1470> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a1a90> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a18d0> 2018-03-18 22:08:53,883 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a1748> 2018-03-18 22:08:53,884 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a1c88> 2018-03-18 22:08:53,884 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a72e8> 2018-03-18 22:08:53,884 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a7128> 2018-03-18 22:08:53,884 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a1f60> 2018-03-18 22:08:53,884 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a74e0> 2018-03-18 22:08:53,884 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a7b00> 2018-03-18 22:08:53,884 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a7940> 2018-03-18 22:08:53,884 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a77b8> 2018-03-18 22:08:53,884 456855 MainThread: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fca182a7cf8> libgcc_s.so.1

Python 3.5.2

PIP install Method

desbma commented 6 years ago

I have reproduced this issue and have made a fix for it. You can test is by installing from sources, or wait for version 2.0.7 to be released. However this is only a warning that clutters the output, and @RealPiHalbe it does not explain why the cover files is not saved. It you are sure the cover file is not created, please open another issue.

jackalblood commented 6 years ago

Hi as you know I installed the new version using the source instructions above and am still receiving this error just commenting to keep track of developments

desbma commented 6 years ago

@jackalblood Does it happen only when you use sacad_r or also with a single invocation of sacad?

jackalblood commented 6 years ago

Main: jpegoptim could not be found, JPEG crunching will be disabled Main: optipng could not be found, PNG crunching will be disabled GoogleImagesWebScrapeCoverSource: Got 10 relevant (10 excluded) results from source 'GoogleImagesWebScrapeCoverSource' LastFmCoverSource: Got 0 relevant (5 excluded) results from source 'LastFmCoverSource' AmazonCdCoverSource: Got 10 relevant (1 excluded) results from source 'AmazonCdCoverSource' AmazonDigitalCoverSource: Got 5 relevant (0 excluded) results from source 'AmazonDigitalCoverSource' Cover: Removed 1 duplicate results Cover: Reference is: LastFmCoverSourceResult 'https://lastfm-img2.akamaized.net/i/u/300x300/07f492a00c904cc6ccf868010be4d5a6.png' AmazonCdCoverSource: Querying 'https://images-na.ssl-images-amazon.com/images/I/61P-NWyDvCL._AC_US218_.jpg' failed (attempt 1/3): TimeoutError GoogleImagesWebScrapeCoverSource: Querying 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRRrZ6B6AFqLJlEELlepO9phpQOcCbjR4xh2eHVfRJ27Vy0kMyI' failed (attempt 1/3): TimeoutError AmazonCdCoverSource: Querying 'https://images-na.ssl-images-amazon.com/images/I/61xvx9OvwyL._AC_US218_.jpg' failed (attempt 1/3): TimeoutError AmazonCdCoverSource: Querying 'https://images-na.ssl-images-amazon.com/images/I/61xvx9OvwyL._AC_US218_.jpg' failed (attempt 1/3): TimeoutError AmazonCdCoverSource: Querying 'https://images-na.ssl-images-amazon.com/images/I/51Yp1Ct2DCL._AC_US218_.jpg' failed (attempt 1/3): TimeoutError AmazonCdCoverSource: Querying 'https://images-na.ssl-images-amazon.com/images/I/519ZXOc3EuL._AC_US218_.jpg' failed (attempt 1/3): TimeoutError AmazonCdCoverSource: Querying 'https://images-na.ssl-images-amazon.com/images/I/613SS4MAp2L._AC_US218_.jpg' failed (attempt 1/3): TimeoutError AmazonCdCoverSource: Querying 'https://images-na.ssl-images-amazon.com/images/I/5124tOpT8XL._AC_US218_.jpg' failed (attempt 1/3): TimeoutError GoogleImagesWebScrapeCoverSource: Querying 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcQ7dyIq9oKywqWpemj2Cx7aMJmJiehxVJM7mJOe5ks9Jw4001wqVw' failed (attempt 1/3): TimeoutError Cover: Download of 'https://images-na.ssl-images-amazon.com/images/I/610wTeA+oyL._AC_US218_.jpg' failed: CancelledError Cover: Download of 'https://images-na.ssl-images-amazon.com/images/I/515u8NYeqWL._AC_US218_.jpg' failed: CancelledError Cover: Download of 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcR5Xv_p3uifPKh4yzbRltpkG0PRFWReKRgs6CXFnVzSySOLZpUS' failed: CancelledError Cover: Download of 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcTGICo2wxuvcnZgTM6LKmn-5wdzl0TA4hZI4cnpCIil4ExsqkueLA' failed: CancelledError Cover: Download of 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcSA7vWOh1mZoq-eSWSiIQN5NhCcAPT36s5e7xO7EmSwxWu8fUjrig' failed: CancelledError Cover: Download of 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcTjNwCQK6SvHK3GrC9vIRSgVaM77VhZgF2yVSCO8zt1OuCPlEuo5g' failed: CancelledError Cover: Download of 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcSlNXYq517QaepT9Pz7BHmcPgCUx7xDi6nwh6affY7aJu5BPaGD' failed: CancelledError Cover: Download of 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcR2GOLaLbMxLcHT33RxL6_X0lVOcjSeKv8zmAUYa3FdGC_cHTMG' failed: CancelledError Cover: Download of 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcSGaqlbLBsS52Jcbxl2ICXpoYJkxIDOqk5yqHzDnOhPYCV2oI-k' failed: CancelledError Cover: Download of 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcR_oA8u3Hm3RzhqG2EdEgn0hQTOCIz4Wb59EjUuYvHdYoejchl4ZA' failed: CancelledError LastFmCoverSource: Querying 'https://lastfm-img2.akamaized.net/i/u/34s/07f492a00c904cc6ccf868010be4d5a6.png' failed (attempt 1/3): TimeoutError Cover: Downloading cover 'https://images-na.ssl-images-amazon.com/images/I/810AxLh7%2BQL._SL1425_.jpg' (part 1/1)... Cover: Resizing from 1425x1425 to 600x600... asyncio: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7f8735e6b588> asyncio: Unclosed connector connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x7f873408a668>, 15713.533382197), (<aiohttp.client_proto.ResponseHandler object at 0x7f873400d6d8>, 15713.580297023)]'] connector: <aiohttp.connector.TCPConnector object at 0x7f8735e6b550> asyncio: Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7f8735e78da0> asyncio: Unclosed connector connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x7f87340f0e80>, 15713.507492309), (<aiohttp.client_proto.ResponseHandler object at 0x7f873400da20>, 15713.510065343), (<aiohttp.client_proto.ResponseHandler object at 0x7f873400d710>, 15713.510151), (<aiohttp.client_proto.ResponseHandler object at 0x7f873408ac18>, 15713.511892846), (<aiohttp.client_proto.ResponseHandler object at 0x7f873400d048>, 15713.516808868), (<aiohttp.client_proto.ResponseHandler object at 0x7f873408ae80>, 15713.539940098), (<aiohttp.client_proto.ResponseHandler object at 0x7f873408a7b8>, 15714.388692204)]'] connector: <aiohttp.connector.TCPConnector object at 0x7f8735e78dd8>

This is the output from running

sacad "metallica" "master of puppets" 600 AlbumArt.jpg.

desbma commented 6 years ago

@jackalblood I can not reproduce the "Unclosed blah blah" warnings with the latest version. I'm in the process of doing code cleanups and dropping support for Python 3.4 before releasing version 2.1.0, maybe that will fix your issue.

desbma commented 6 years ago

@jackalblood I have just released version 2.1.0, which should fix the last remaining "Unclosed client session" errors, please test it to check if the issue is indeed fixed.

jackalblood commented 6 years ago

Hi there

Sorry it took so long to reply ive been ill this week

i tried the new version from the github clone and setup method and i'm afraid i'm back where i started with the downloader just stuck no output besides this

Analyzing library: 744 dirs [01:27, 15.00 dirs/s, files=7.71e+03, albums=624, mi Analyzing library: 744 dirs [01:27, 15.00 dirs/s, files=7.72e+03, albums=625, mi Analyzing library: 745 dirs [01:27, 8.50 dirs/s, files=7.72e+03, albums=625, mi ssing covers=618, errors=1] Unable to read metadata for album directory '/home/joemannix8/Media/Music/Death Cab for Cutie/Narrow Stairs (2008)' Searching covers: 0%| | 0/617 [00:00<?, ? covers/s, errors=0, no result found= 0, ok=0]

desbma commented 6 years ago

Thanks for the update.

This issue is about the "Unclosed client session" warning, can you confirm it is gone both for sacad and sacad_r?

I have reopen https://github.com/desbma/sacad/issues/17 for the "freeze" issue.

jackalblood commented 6 years ago

I left it overnight and was presented with the "unclosed client connection" error when I woke up

desbma commented 6 years ago

When you run a single sacad invocation, do you get the "unclosed client" message?

When you left sacad_r running for a long time, do you get a single "unclosed client" message, or dozens like before?

jackalblood commented 6 years ago

sacad "metallica" "master of puppets" 600 AlbumArt.jpg ran perfectly

So only sacad_r results in the issue and it appears multiple times like before

desbma commented 6 years ago

I'm closing this issue for lack of activity, and because it is likely fixed. Feel free to comment on it if you have anything new.