search

descampsa / yuv2rgb

C99 library for fast image conversion between yuv420p and rgb24
BSD 3-Clause "New" or "Revised" License
170 stars 62 forks source link

Code Style And FFMPEG bench code #5

Closed LuoZijun closed 2 years ago

LuoZijun commented 7 years ago

just an suggestion for detach ffmpeg test code.

descampsa commented 7 years ago

Could you please split this pull request in two, one for code style, and one for the bench code? The easiest way is to do a new branch in your repository for each pull request.

Regarding code style, i know it is a matter of personnal preference, but i prefer indentations with tabulations, could you update your commits with tabulations instead of spaces? It will make it easier for me to review the 'real' changes.

Regarding the bench code, could you describe what it does exactly, and how it is different/better than my test application?

Thanks a lot for your contribution :+1: