Different order of (estimates, reference) in SISDR Loss forward

descriptinc / audiotools

Object-oriented handling of audio data, with GPU-powered augmentations, and more.

https://descriptinc.github.io/audiotools/

MIT License

218 stars 37 forks source link

Different order of (estimates, reference) in SISDR Loss forward #96

Open seastar105 opened 1 year ago

seastar105 commented 1 year ago

while other metrics accept (estimates, reference) in function call, SISDR takes (reference, estimates) in function call which makes confusing and easy-to-mistake. need change!

https://github.com/descriptinc/audiotools/blob/49b8b6bb9259a99bda5f2138a1a4df055dd172ef/audiotools/metrics/distance.py#L83-L91