Always use Sass - Githubissues

deseretdigital-ui / CSS-Guidelines

High-level guidelines for writing manageable, maintainable CSS

0 stars 0 forks source link

Always use Sass #20

Open jehoshua02 opened 9 years ago

jehoshua02 commented 9 years ago

Even if you are just going to write vanilla css, I'd like every project setup to use gulp-sass. The biggest benefit is being able to easily separate styles into multiple files, which we badly need to do, especially with our new emphasis on writing everything to be reusable.

Before Closing Issue:

[x] Response from @jstoutenburg
[x] Response from @janiv
[x] Response from @kbratko
[x] Response from @jspencerDDM
[ ] Consensus or Decision
[ ] Pull request or other action if necessary

rsahlstrom commented 9 years ago

Sass should be a requirement. Gulp-sass should not be.

jehoshua02 commented 9 years ago

In general, I think we should be using gulp-sass. But there are good reasons when we wouldn't use gulp-sass:

If we decide to use webpack, it compiles sass already.
If we are using ember-cli, it compiles sass already using broccoli.
If a project is already using some other build tool.

hhatfield commented 9 years ago

I agree that sass is right, but the tool-chain needs to be able to vary.

jehoshua02 commented 9 years ago

I'm fine with allowing toolchain to vary as long as build configuration is committed to the repository and the output is essentially the same.