search

deseretdigital / dayzed

Primitives to build simple, flexible, WAI-ARIA compliant React date-picker components.
https://dayzed.netlify.app
MIT License
664 stars 27 forks source link

Proposal: Turn components in examples into reusable components #24

Closed donysukardi closed 6 years ago

donysukardi commented 6 years ago

Currently the library only exposes Dayzed component. What if we turn all the components in examples into reusable ones, i.e. RangeDatePicker, MultiDatePicker, DatePicker, while still exposes the render props to userland?

mkartchner994 commented 6 years ago

I like the idea, but I am wondering if this would be better served as the goal of a different project that uses the Dayzed component under the hood. I am concerned that if we add the different Datepicker components, the Dayzed component's upgrade path would become tightly coupled with the other Datepickers making it more difficult to add new ideas to Dayzed when they come up.

I think Dayzed could be useful for more than just Datepickers. For example, It could also be used to create a custom google calendar like layout which doesn't deal with selecting specific dates, but showing events on those days instead.

Thoughts?

donysukardi commented 6 years ago

You bring up a really good point. We could definitely maintain the components as a separate project.

Do you mind if I create a new library out of https://github.com/deseretdigital/dayzed/pull/25 then? Any suggestion for the package name? dayzed-pickers?

mkartchner994 commented 6 years ago

Yes, if you would like to create the new lib that would be great! dayzed-pickers sounds good to me 👍