search

deseretdigital / dayzed

Primitives to build simple, flexible, WAI-ARIA compliant React date-picker components.
https://dayzed.netlify.app
MIT License
660 stars 27 forks source link

Pass the event to the onDateSelected callback #34

Closed arthurdenner closed 4 years ago

arthurdenner commented 4 years ago

Hi! :wave:

I'm trying to work on this issue, but I can't achieve it at the moment because we are not passing the event to the onDateSelected callback here.

Are you in favor of adding it as a second argument (to prevent a breaking change)?

If so, I'd like to work on it :)

arthurdenner commented 4 years ago

@mkartchner994, do you have any thoughts on this?

mkartchner994 commented 4 years ago

I think that makes sense. If you want to work on it that would be great. Thanks @arthurdenner!

mkartchner994 commented 4 years ago

Rouge button click that closed the issue 🤦‍♂

mkartchner994 commented 4 years ago

@arthurdenner This was released as v3.1.0 - https://github.com/deseretdigital/dayzed/releases/tag/v3.1.0

Thanks for the PR!

arthurdenner commented 4 years ago

Thanks for the quick approval and release! :smiley: