search

deshanadesai / acorns

https://arxiv.org/pdf/2007.05094.pdf An Easy-To-Use Code Generator for Gradients and Hessians
MIT License
30 stars 6 forks source link

Fix project structure #1

Closed marcelotrevisani closed 4 years ago

marcelotrevisani commented 4 years ago

Hi @deshanadesai , I created this PR with the intention to fix the project structure, I added the package_dir on setup.py which points to src and I moved the files on src to a folder called acorns So in that way when you install this project you will be able to use

import acorns

instead of 

import src

src is too generic and you may face some problems in the future because of that :grimacing:

deshanadesai commented 4 years ago

Hi @deshanadesai , I created this PR with the intention to fix the project structure, I added the package_dir on setup.py which points to src and I moved the files on src to a folder called acorns So in that way when you install this project you will be able to use

import acorns

instead of

import src

src is too generic and you may face some problems in the future because of that 😬

Made complete sense. I ended up removing src entirely and refactored the code to make it more package friendly. Thank you for your help! Really appreciate it.