deshaw / pyflyby

A set of productivity tools for Python
https://deshaw.github.io/pyflyby/
Other
353 stars 52 forks source link

Cleanup #222

Closed Carreau closed 1 year ago

Carreau commented 1 year ago

MAINT: Move closure into standalone function.

Expand error messages.

Update test. "there" is the name of a module.

If it is locally installed it makes the test fail.

codecov-commenter commented 1 year ago

Codecov Report

Base: 72.60% // Head: 72.60% // No change to project coverage :thumbsup:

Coverage data is based on head (1be29e5) compared to base (854fe89). Patch coverage: 69.23% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #222 +/- ## ======================================= Coverage 72.60% 72.60% ======================================= Files 25 25 Lines 7979 7979 ======================================= Hits 5793 5793 Misses 2186 2186 ``` | [Impacted Files](https://codecov.io/gh/deshaw/pyflyby/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw) | Coverage Δ | | |---|---|---| | [lib/python/pyflyby/\_importstmt.py](https://codecov.io/gh/deshaw/pyflyby/pull/222/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19pbXBvcnRzdG10LnB5) | `83.07% <69.23%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.