search

deshaw / pyflyby

A set of productivity tools for Python
https://deshaw.github.io/pyflyby/
Other
353 stars 52 forks source link

Add support for a tidy-import comm #247

Closed divyansshhh closed 1 year ago

divyansshhh commented 1 year ago

See also https://github.com/deshaw/jupyterlab-pyflyby/pull/14

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 72.41% and project coverage change: -3.17 :warning:

Comparison is base (238edc2) 72.69% compared to head (89a847c) 69.52%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #247 +/- ## ========================================== - Coverage 72.69% 69.52% -3.17% ========================================== Files 25 25 Lines 8034 8334 +300 ========================================== - Hits 5840 5794 -46 - Misses 2194 2540 +346 ``` | [Impacted Files](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw) | Coverage Δ | | |---|---|---| | [lib/python/pyflyby/\_\_init\_\_.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | | | [lib/python/pyflyby/\_\_main\_\_.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19fbWFpbl9fLnB5) | `33.33% <ø> (-16.67%)` | :arrow_down: | | [lib/python/pyflyby/\_docxref.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19kb2N4cmVmLnB5) | `0.00% <ø> (-79.27%)` | :arrow_down: | | [lib/python/pyflyby/\_file.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19maWxlLnB5) | `91.82% <ø> (+3.82%)` | :arrow_up: | | [lib/python/pyflyby/\_flags.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19mbGFncy5weQ==) | `89.68% <ø> (-0.09%)` | :arrow_down: | | [lib/python/pyflyby/\_format.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19mb3JtYXQucHk=) | `88.05% <ø> (-0.18%)` | :arrow_down: | | [lib/python/pyflyby/\_importclns.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19pbXBvcnRjbG5zLnB5) | `81.25% <ø> (-0.07%)` | :arrow_down: | | [lib/python/pyflyby/\_importdb.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19pbXBvcnRkYi5weQ==) | `80.70% <ø> (+4.38%)` | :arrow_up: | | [lib/python/pyflyby/\_imports2s.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19pbXBvcnRzMnMucHk=) | `92.30% <ø> (-0.03%)` | :arrow_down: | | [lib/python/pyflyby/\_interactive.py](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw#diff-bGliL3B5dGhvbi9weWZseWJ5L19pbnRlcmFjdGl2ZS5weQ==) | `46.02% <ø> (-5.82%)` | :arrow_down: | | ... and [15 more](https://app.codecov.io/gh/deshaw/pyflyby/pull/247?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deshaw) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

divyansshhh commented 1 year ago

Looking at Github Actions logs, I'm pretty sure the test for lint isn't working. I'll fix that as well.