:bug: fix - Do not sort imports

deshaw / pyflyby

A set of productivity tools for Python

https://deshaw.github.io/pyflyby/

Other

347 stars 52 forks source link

Closed dshivashankar1994 closed 5 months ago

dshivashankar1994 commented 5 months ago

The sort_imports feature introduced has several issues. So do not use it till #287 is sorted

Request: PyInf#12353

Carreau commented 5 months ago

I'm confused, was there an issue with importing sort_import ? #309 should have already deactivated sorting import.

dshivashankar1994 commented 5 months ago

Yes, if --no-canonicalize is specified, we were trying to use sort_imports and this commit fixed that

Carreau commented 5 months ago

Ah, yes sorry I see the typo now.