desht / ModularRouters

A Forge Mod for item routers with pluggable modules
16 stars 20 forks source link

Regulator augment not updating when entering the value through the keyboard. #114

Closed Cerbrus closed 3 years ago

Cerbrus commented 3 years ago

Minecraft Version

1.16

Forge Version

1.16.4-forge-35.1.36

I'm using the "FTB Presents Direwolf20 1.16" modpack, version 1.4.1

Mod Version

modular-routers-1.16.4-7.3.0-47

Describe your problem, including steps to reproduce it

The regulator augment, when inserted in a player module, doesn't update the value when you type in the input field.
Only when you scroll in the input field, you'll see the augment's item count update, on the player module.

desht commented 3 years ago

Sorry, not seeing that behaviour. Typing in the augment's textfield works just fine for me.

Jimmeh42 commented 3 years ago

I have had this issue with the FTB Direwolf20 pack for 1.16 it must be a conflict with another mod causing it. Using the scroll wheel while hovering over the augment slot works correctly.

desht commented 3 years ago

Hmm, do you see a warning like the following in the server log?

[14:49:35] [Server thread/WARN] [me.de.mo.ModularRouters/]: ignoring ModuleSettingsMessage for desht - expected module not found @ me.desht.modularrouters.util.MFLocator@40b1c8af
desht commented 3 years ago

Yeah, found the problem. Will be fixed in 7.4.0.

Keypresses were being passed through the GUI and not swallowed by the textfield, causing the held item to be changed. So when the client sent the update packet, the held item was no longer what the server was expecting, so it ignored the update.

desht commented 3 years ago

Fixed in 7.4.0