search

desht / ModularRouters

A Forge Mod for item routers with pluggable modules
18 stars 20 forks source link

Remove 'noOcclusion' from the block properties to fix the router rendering underwater. #135

Closed Flanks255 closed 3 years ago

Flanks255 commented 3 years ago

'noOcclusion' is making minecraft think the router is transparent, and then rendering the water surface around it when it is underwater. java_2021-07-15_15-34-40 java_2021-07-15_15-52-28

Flanks255 commented 3 years ago

guess nevermind for now until a method to dynamically control the solidness of the block can be found...

desht commented 3 years ago

As discussed on Discord, overriding shouldDisplayFluidOverlay() in the router block appears to remedy the rendering problem. Will test a bit more before next release though; in particular to check what happens if the router is camo'd as a non-solid block (e.g. a flower). Might need to return the camo state's shouldDisplayFluidOverlay() rather than simply returning true.