search

desht / ModularRouters

A Forge Mod for item routers with pluggable modules
18 stars 20 forks source link

Modular Router compat with Bedrock Ores #169

Closed Raidobw2 closed 2 years ago

Raidobw2 commented 2 years ago

Describe the feature

Bedrock Ores https://www.curseforge.com/minecraft/mc-mods/dadobug1111s-bedrock-ores-forge is a mod that adds infinite ores to the game.

Currently, the breaker module from Modular Routers breaks the block. I would like to suggest allowing some tag or checking for that mod's tag so that bedrock ores (or if custom tag, any block), can be prevented from breaking and being replaced with air.

Reasons why it should be considered

Players should not be able to mine bedrock-like materials and this adds value to Modular Routers so it can be used to farm those ores instead of opening a path to the void

Additional details

Relayed from https://github.com/FTBTeam/FTB-Modpack-Issues/issues/1062

Also reported to Bedrock Ores at https://github.com/dadobug1111/DadobugBedrockOres/issues/10

image

desht commented 2 years ago

If Modular Routers is able to break the block, then the block isn't unbreakable. Maybe Bedrock Ores is using some trickery to cancel a break, but the block needs to have a negative destroyTime to be properly unbreakable (like vanilla Bedrock or Ender Portal blocks do). And it's clear that this fake bedrock doesn't have a negative destroyTime.

I don't plan to make any changes to Modular Routers for this, sorry. This is on Bedrock Ores to fix. (Yes, I could add a kludge to MR, but that's the wrong way to do it. And any other mod with a block breaker would also have to adjust for this too. Bedrock Ores is the mod adding a block with weird behaviour; it's on it to play nice with other mods).

Raidobw2 commented 2 years ago

I see you commented as well on the linked issue. Thank you very much for the comments and explanation, I hope the mod author from Bedrock Ores will be able to figure out a solution with your insight 😄 Have a good weekend!