search

desht / ModularRouters

A Forge Mod for item routers with pluggable modules
16 stars 20 forks source link

Add indicator for missing energy required for operation #217

Closed johalun closed 4 months ago

johalun commented 4 months ago

Describe the feature

When a module requires FE to operate, there should be an indicator that will let the player know FE is required for the module to work.

Reasons why it should be considered

Attack entity operation requires energy by default. Other operations can be configured to require energy. However, there's no indication show that FE is required and players might be confused wondering why their router doesn't work when they play on a server with custom energy config options.

Additional details

No response

desht commented 4 months ago

Hmm? You mean this?

image

johalun commented 4 months ago

Indeed that shows for the entity attack mode which is enabled by default. However, I have set a FE requirement for right-clicking and breaking and it doesn't show that for those. Edit: I have confirmed in-game that the modules won't do anything without FE supply. Edit 2: I only changed the config server side first. Changing client side also fixed the issue. Is this expected behavior?

desht commented 4 months ago

Yeah, it's using common config to set these values so it is intended. The config isn't synced from server to client.

johalun commented 4 months ago

Ah so that why the functionality is correct (i.e. for operation it's using server side config), whilst the UI is using client side config? We just have to make sure to keep them in sync then so the players won't get confused why the modules aren't working.

desht commented 4 months ago

Yeah, ideally this would be sync'd, but I'd be concerned about breaking backwards compat (moving from common to server config). Maybe for 1.20.4+ :)