search

design-ops / sketch-to-swiftUI

24 stars 5 forks source link

Include jsdom in the dependencies so getting assets works #13

Closed kerrmarin closed 4 years ago

kerrmarin commented 4 years ago

I don't really know enough about npm and why we're not picking up jsdom from the sketch-to-svg node_modules but this fixes it so we can export assets...

Fixes #5

atomoil commented 4 years ago

Hmm, something about this smells wrong. Presuming jsdom is only used in to-svg then that’s likely really an issue there not here On 10 Apr 2020, 18:39 +0100, Kerr Marin Miller notifications@github.com, wrote:

@kerrmarin requested your review on: #13 Include jsdom in the dependencies so getting assets works. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.