design-sparx / antd-multipurpose-dashboard

A free, open source, Vite, Typescript admin theme created using Ant Design 5
https://antd-multipurpose-dashboard.netlify.app/
MIT License
88 stars 23 forks source link

chore: change onboarding flow. From landing → login → home #87

Closed kelvink96 closed 5 months ago

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 8a5f6efcb0971c97782e5933d9f59e0605490564

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | antd-multi-dashboard | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gitguardian[bot] commented 5 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [10162513](https://dashboard.gitguardian.com/incidents/10162513?occurrence=128054479) | Triggered | Generic Password | 9710a8e8b4d75dc3576f7bf7cfa795749c76da50 | src/pages/authentication/SignIn.tsx | [View secret](https://github.com/design-sparx/antd-multipurpose-dashboard/commit/9710a8e8b4d75dc3576f7bf7cfa795749c76da50#diff-d17ee4f6a2aa573e16f192a24f8efafdb453e812d031d2f8c9dda4ef17011d99R99) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

netlify[bot] commented 5 months ago

Deploy Preview for antd-multipurpose-dashboard failed.

Name Link
Latest commit 8a5f6efcb0971c97782e5933d9f59e0605490564
Latest deploy log https://app.netlify.com/sites/antd-multipurpose-dashboard/deploys/660c5c60cc13230008ba1b80
notion-workspace[bot] commented 5 months ago

Change onboarding flow. From landing → login → home