design-tokens / community-group

This is the official DTCG repository for the design tokens specification.
https://tr.designtokens.org
Other
1.56k stars 63 forks source link

Chore: Upgrade Node to v22, update deps #242

Closed drwpow closed 2 months ago

drwpow commented 3 months ago

Changes

Reviewing

netlify[bot] commented 3 months ago

Deploy Preview for dtcg-tr ready!

Name Link
Latest commit 2777c5aba2bf4e51b68adfda52db153902db3952
Latest deploy log https://app.netlify.com/sites/dtcg-tr/deploys/66cebc76bc02a80008730786
Deploy Preview https://deploy-preview-242--dtcg-tr.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kaelig commented 3 months ago

I just updated the Netlify Site configuration to use Node v20. Node v22 should work too, but isn't fully supported.

kaelig commented 3 months ago

Looks like Chrome isn't available anymore – can you look into it?

drwpow commented 3 months ago

Looks like Chrome isn't available anymore – can you look into it?

Sorry; what do you mean by Chrome not being available?

kaelig commented 3 months ago

Chrome must have been available in the old build image (see error logs), and isn't available with the Node 22 build image. I believe it's necessary for ReSpec to build.

drwpow commented 2 months ago

Chrome must have been available in the old build image (see error logs), and isn't available with the Node 22 build image. I believe it's necessary for ReSpec to build.

Just added a setup step for Puppeteer in Netlify. I think Netlify caches this well as it was pretty instant.

drwpow commented 2 months ago

I just updated the Netlify Site configuration to use Node v20. Node v22 should work too, but isn't fully supported.

Also that’s fine! Node v20 is fine. I only updated to v22 because it’s been out for a while, it’s the latest stable version, and will be replacing v20 as the new active version in only a couple months. But it’s all fine, as long as we’re upgraded off an EOL version 😅