Closed drwpow closed 3 months ago
Name | Link |
---|---|
Latest commit | e4f734afb64bc5b48ab2340119709d73213250ac |
Latest deploy log | https://app.netlify.com/sites/dtcg-tr/deploys/66c118176c3ed00008fbeb9e |
Deploy Preview | https://deploy-preview-246--dtcg-tr.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
This proposal looks good to me, we'll make adjustments to the color values separately shortly.
Summary
This proposes the following changes to
$type: shadow
tokens:$value
inset
(boolean) propertyReasoning
This PR proposes that the following discussions be resolved like so:
100: ✅ Accepted (all proposals that I saw)
Pros
Cons
Alternatives
inset
required, at the expense of breaking backward compatibility"inset": [boolean]
, we could have something like"position": "inner"
(string enum), but I can’t think of any other value this would be (what is there other than “inside” and “outside”?). Seems like designing for something no one has asked for.Notes