search

designatednerd / DNSSwipeableTableCell

UITableViewCell subclass to add multiple buttons to a swipe-under menu like iOS 7 Mail.
MIT License
175 stars 24 forks source link

DNSSwipeableTableCell has when compiling against iOS 8 #9

Closed mergesort closed 10 years ago

mergesort commented 10 years ago

I'm working on finding the issue, but I'm having trouble so far. I've determined that the problem is with the myContentView property. When I add a subview to UITableViewCell's contentView property, everything looks fine (but obviously swiping does not work). When I add my subview and constrain it to myContentView, it ends up looking like this. Example

Would it be possible to have you look into this? I'm working on it as well, but am having trouble figuring it out.

Thanks!

mergesort commented 10 years ago

I fixed it. It appears you need to call [self layoutIfNeeded] at the end of commonInit to trigger updateConstraints initially. I'll push up a pull request.

designatednerd commented 10 years ago

Thanks @mergesort, I'll keep an eye out for that PR. I'm buried in iOS 8 stuff for Hum but I'm hoping that I can get to a bunch of updates by the end of the month.

mergesort commented 10 years ago

@designatednerd There's already a PR for adding the pop gesture recognizer, and it added this commit onto that PR. https://github.com/designatednerd/DNSSwipeableTableCell/pull/8

designatednerd commented 10 years ago

AH, dammit. I was going to test that. I'll try to look at that tonight.

designatednerd commented 10 years ago

This has been merged (finally).