designforcontext / aac_review_tool

MIT License
5 stars 7 forks source link

Problem with mapping of Dimensions (Part) #62

Closed cathryng closed 7 years ago

cathryng commented 7 years ago

I expected to see:

this data in "physical size of the work" rather than in "physical size of part of the work" - how does this get decided? the element for this dimension is 'overall'

but instead I saw:

data in the part field - no data in the overall dims field

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?value ?part ?part_class ?part_type ?unit ?dimension_name ?dimension_class
WHERE {
<http://data.americanartcollaborative.org/puam/object/3139> a crm:E22_Man-Made_Object ;
    crm:P46_is_composed_of ?part_class.
?part_class a crm:E18_Physical_Thing ;
  crm:P43_has_dimension ?dimension_class .
?dimension_class a crm:E54_Dimension ;
  rdf:value ?value ;
  crm:P91_has_unit ?unit ;
  crm:P2_has_type ?dimension_type .
OPTIONAL {
  ?dimension_type skos:prefLabel ?dimension_name.
}
OPTIONAL {
  ?part_class crm:P2_has_type ?part_type.
}
OPTIONAL {
  ?part_class rdfs:label ?part.
}

}
workergnome commented 7 years ago

I think this is working as intended. It's a little confusing, but "Overall" is a "part", because it describes which part of the object is being described—it's the 'everything' part, but it lets us tell people that's the part.

The other method is more for when nobody specifies what the dimensions refer to, so we have to guess.