designforcontext / aac_review_tool

MIT License
5 stars 7 forks source link

Problem with mapping of Primary Title #70

Open KatherineMoloney opened 7 years ago

KatherineMoloney commented 7 years ago

I expected to see:

Untitled (See America First XI)

but instead I saw:

[no title]

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?primary_title_text ?primary_title_class ?primary_title_id ?primary_title_id_class
WHERE {
<http://data.americanartcollaborative.org/npg/object/49748> a crm:E22_Man-Made_Object ;
  crm:P102_has_title ?primary_title_class .
?primary_title_class a crm:E35_Title ;
  rdf:value ?primary_title_text ;
  crm:P2_has_type <http://vocab.getty.edu/aat/300404670> .
OPTIONAL {
  ?primary_title_class crm:P1_is_identified_by ?primary_title_id_class.
  ?primary_title_id_class a crm:E42_Identifier;
    crm:P2_has_type <http://vocab.getty.edu/aat/300404012> ;
    rdf:value ?primary_title_id .
}

}
kateblanch commented 7 years ago

Hi @KatherineMoloney, awesome work on proofing these objects! Would you mind closing issues 67-70 and leave only issue 71 as a generalized example of the problem? I understand it is indeed affecting many object instances. Save yourself the extra headache of multiple issues! Posting one example of an issue is easier for all, rather than re-posting the issue each time it repeats on an object.

kateblanch commented 7 years ago

Here are URIs to objects missing titles in the review.americanartcollaborative.org tool.

http://data.americanartcollaborative.org/acm/object/090_lc_s59 -- has credit line and homepage only http://data.americanartcollaborative.org/acm/object/015_lc_s611 --has credit line and homepage only http://data.americanartcollaborative.org/acm/object/011_lc_s68

I can't find these objects in the source data, but I'm asking for someone to corroborate that I didn't just miss them. The first two have some minimal data about them, so they must exist somewhere? I'm stumped :(

workergnome commented 7 years ago

@caknoblock: can you help figure out where these are coming from?