search

designforcontext / aac_review_tool

MIT License
5 stars 7 forks source link

use AAT concepts directly rather than local concept with broaderMatch to AAT #8

Open VladimirAlexiev opened 7 years ago

VladimirAlexiev commented 7 years ago

http://review.americanartcollaborative.org/entity/E39_Actor#field_2-search_0 Why not use aat:300404651 directly but do this broadMatch rigmarole? Is any institution actually using local concepts for ?given_name_type?

  ?given_name_type_class a crm:E55_Type ;
    skos:broadMatch <http://vocab.getty.edu/aat/300404651> .
    skos:prefLabel ?given_name_type.
workergnome commented 7 years ago

Honestly, I agree with you here, and I wish I'd caught this before. I'm going to leave this open so we can fix it in the next version—I don't know that I can convince the students to correct this en masse at this point.

VladimirAlexiev commented 7 years ago

Reiterating the point above:

cbm:person-institution/111/appellation/firstname a crm:E82_Actor_Appellation;
  crm:P2_has_type cbm:person-institution/111/appellation/name_type/firstname
  rdf:value "George".
cbm:person-institution/111/appellation/name_type/firstname a crm:E55_Type;
  skos:broadMatch aat:300404651; # first name
  skos:prefLabel "First Name".

The node cbm:person-institution/111/appellation/name_type/firstname is useless because it doesn't say anything more than aat:300404651. Presumably it gives museums the freedom to have their own concept for First Name, not that such freedom is needed or desired.

What's worse is that the useless node is replicated for EVERY instance of a first name. Reported as https://github.com/american-art/cbm/issues/59.