search

designly1 / nextjs13-progress

An implementation of n-progress for use with the Next.js 13 app router.
MIT License
13 stars 5 forks source link

Expose progress bar link click event. Move href check within this fun… #2

Closed gamma613 closed 9 months ago

gamma613 commented 9 months ago

  1. Expose the progress bar link click event, folks can write their own custom Link component and handle the event themselves if desired

  2. instead of checking existence / properties of href attribute upon component instantiation, check it using this function in realtime.

designly1 commented 9 months ago

  1. Expose the progress bar link click event, folks can write their own custom Link component and handle the event themselves if desired

    1. instead of checking existence / properties of href attribute upon component instantiation, check it using this function in realtime.

Could you update the README too with a short explanation? Thanks for your contribution!

designly1 commented 9 months ago

Also, feel free to add yourself as a contributor to the package.json :-)

gamma613 commented 9 months ago

Good call! Added, with some basic examples. Hopefully it's clear

designly1 commented 9 months ago

Merged and closed. Thank you! ;_)

gamma613 commented 9 months ago

I took a look at the latest on npm but the changes don't seem to be appearing. I am wondering if the new package may have skipped the build process or used a cached build?

designly1 commented 9 months ago

I see that. I deleting everything and rebuilt. Tsup is kind of weird sometimes. Or it's very possible I just forgot to run it. :D Published as 1.2.1.

Jay

------ Original Message ------ From "Steven McCoy" @.> To "designly1/nextjs13-progress" @.> Cc "Jay Simons" @.>; "State change" @.> Date 1/2/2024 9:04:34 AM Subject Re: [designly1/nextjs13-progress] Expose progress bar link click event. Move href check within this fun… (PR #2)

I took a look at the latest on npm but the changes don't seem to be appearing. I am wondering if the new package may have skipped the build process or used a cached build?

— Reply to this email directly, view it on GitHub https://github.com/designly1/nextjs13-progress/pull/2#issuecomment-1874141136, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALHCNZEXNRCPVJ3GM4QS6U3YMQOYFAVCNFSM6AAAAABBAAHIV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUGE2DCMJTGY. You are receiving this because you modified the open/close state.Message ID: @.***>