designly1 / nextjs13-progress

An implementation of n-progress for use with the Next.js 13 app router.
MIT License
13 stars 5 forks source link

Added Target props and some other important props. #6

Closed Abdulrahim2567 closed 4 months ago

Abdulrahim2567 commented 4 months ago

I created this pull request to solve the issue when TS throws an error when we try to use the target prop on the patched link component. I also added other useful props one may need when working with this link element.

designly1 commented 4 months ago

That looks like it did it. Thanks again!

Jay

------ Original Message ------ From "Abdulrahim2567" @.> To "designly1/nextjs13-progress" @.> Cc "Subscribed" @.***> Date 5/25/2024 4:22:06 AM Subject [designly1/nextjs13-progress] Added Target props and some other important props. (PR #6)

I created this pull request to solve the issue when TS throws an error when we try to use the target prop on the patched link component. I also added other useful props one may need when working with this link element.


You can view, comment on, or merge this pull request online at: https://github.com/designly1/nextjs13-progress/pull/6

Commit Summary f4cad5f https://github.com/designly1/nextjs13-progress/pull/6/commits/f4cad5f45c330b79f286c5314d906d10546ef0aa have added the target prop as well as other useful link props b8bb0fa https://github.com/designly1/nextjs13-progress/pull/6/commits/b8bb0fa4632436ce7d55be259eb6c46668945779 modified props File Changes (1 file https://github.com/designly1/nextjs13-progress/pull/6/files)

Msrc/lib/router-events/patch-router/link.tsx https://github.com/designly1/nextjs13-progress/pull/6/files#diff-841f34336d720abfe5f0ba1ebfbfc73f64b5c42cb1b778b80c718d56f19cbb23 (13) Patch Links: https://github.com/designly1/nextjs13-progress/pull/6.patch https://github.com/designly1/nextjs13-progress/pull/6.diff — Reply to this email directly, view it on GitHub https://github.com/designly1/nextjs13-progress/pull/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALHCNZCMAVDCVGVUFF67Q5LZEBJ35AVCNFSM6AAAAABIIX2GE6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTMOBWG4YDSMQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Abdulrahim2567 commented 4 months ago

My pleasure!