designmynight / laravel-mongodb-passport

A package to get Laravel Passport working with MongoDB
MIT License
67 stars 75 forks source link

Support for new laravel-mongodb version #18

Closed vaishnavmhetre closed 5 years ago

vaishnavmhetre commented 5 years ago

Allowing version jenseggers/laravel-mongodb = 3.5.* to patch critical problem [jenssegers/laravel-mongodb/pull/1712]

It will be a breaking change as it is specific to laravel = "5.8" and will not work for any laravel = "<5.8" Hence recommended to release new version with this change applied specifically for laravel = "5.8".

willtj commented 5 years ago

Looks good to me, thanks. This change will support extra versions of jenssegers/mongodb but it won't require anyone to update so I don't think this alone needs to be considered a breaking change.

divine commented 5 years ago

@willtj current passport version is 7.2.1 maybe add that version too? I have tested and looks good.