search

desihub / QuasarNP

Pure Numpy implementation of QuasarNet
MIT License
0 stars 0 forks source link

Remove scipy dependency? #2

Closed dkirkby closed 3 years ago

dkirkby commented 3 years ago

It looks like you only need scipy for 1d linear interpolation here:

    i_to_wave = interp1d(arange(len(wave)), wave, 
            bounds_error=False, fill_value='extrapolate')

Can you replace this with np.interp and remove scipy from the setup.py dependencies? You won't get the extrapolation but is this actually necessary? It would be nice to remove this heavyweight dependency (even though plenty of other DESI packages use it).