search

desihub / boss2desi

code to convert boss data to desi format
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

missing FLAVOR #6

Open londumas opened 6 years ago

londumas commented 6 years ago

doss2desi bricks miss the "FLAVOR" flag. It is defined as: Flavor [arc, flat, science, ...] (py/desispec/test/pipehelpers.py)

When running on boss2desi bricks I get:

rrdesi --zbest zbest.fits --output rrdetails.h5 /uufs/chpc.utah.edu/common/home/sdss02/ebosswork/eboss/sandbox/desiwork/boss2desi/v0.11/brass/bricks/4220/brick-b-4220.fits
INFO: reading targets
ERROR:frame.py:174:vet: Frame.meta missing FLAVOR keyword
/uufs/astro.utah.edu/common/home/u6011908/Programs/desi/code/desispec/py/desispec/io/frame.py:170: UserWarning: Frame did not pass simple vetting test. diagnosis=2
  warnings.warn("Frame did not pass simple vetting test. diagnosis={:d}".format(diagnosis))
ERROR:frame.py:171:read_frame: Frame did not pass simple vetting test. diagnosis=2
sbailey commented 6 years ago

@ngbusca can you look into this? Science frames should have FLAVOR keyword "science" in the output files. Or @londumas you are welcome to submit a patch for boss2desi to fix that.

We could also consider making this a non-fatal error when reading the spectra, since I don't think we actually need FLAVOR for anything in redrock itself. I think that would require an update to desispec.io.readframe.

londumas commented 6 years ago

@sbailey, it isn't a fatal error. it is a warning.

sbailey commented 6 years ago

@londumas thanks for clarifying. That takes the pressure off. It would still be good for boss2desi to fill in that keyword, but glad to know that isn't a blocking factor for using those files.

ngbusca commented 6 years ago

This is a known issue. Please let me know offline what you are trying to do with these boss bricks, there are many "known issues" like this one.