desihub / desiconda

Tools to install DESI dependencies from scratch.
BSD 3-Clause "New" or "Revised" License
1 stars 7 forks source link

Ensure that lib directories are added to LD_LIBRARY_PATH #14

Closed weaverba137 closed 6 years ago

weaverba137 commented 6 years ago

Make sure that the conda lib directory is added to LD_LIBRARY_PATH in addition to the aux lib directory. See desihub/desiconda#13.

tskisner commented 6 years ago

Actually this should never be done. The conda lib directory contains incompatible libraries (tcl, hdf5, etc) that shadow system libraries. Adding the conda lib directory to LD_LIBRARY_PATH breaks things like modules. In fact, this was the original reason for having the "aux" directory in the first place (so that we could put stuff in LD_LIBRARY_PATH without bringing in all of the conda libraries.

weaverba137 commented 6 years ago

OK, fair enough. And also I put the wrong issue link in the original report. I was trying to reference desihub/desimodules#13, where a bug was fixed by explicitly adding the conda lib directory to LD_LIBRARY_PATH. Can you please take a look at that?

weaverba137 commented 6 years ago

Based on this discussion, I'm labeling this as 'wontfix'. Feel free to close.

tskisner commented 6 years ago

Yes, that desiconda should really, really not be used any more. It has other fundamental problems since it was created before we understood the perils of mixing gcc + MKL + python. Hopefully soon we'll move to the latest desiconda from 01/30/2018.