I think there may be places in desimeter where we should add checks that the current petal-alignments.yaml matches whatever was in the online constants DB at the time of the measurement.
For example when we are doing best fits to discover OFFSET_X, OFFSET_Y based on historical data, then this may be important.
I think the simplest and cleanest test is:
Get OBS_X, OBS_Y and PTL_X, PTL_Y from the online DB. Here the PTL values were generated in the online system by applying the Constants DB transformation params to OBS.
Use desimeter / petal-alignments.yaml to do the analagous conversion into PTL. (Note OBS == what desimeter calls X_FP, Y_FP.)
Check that PTL values from (1) and (2) should exactly match.
I think there may be places in desimeter where we should add checks that the current
petal-alignments.yamlmatches whatever was in the online constants DB at the time of the measurement.For example when we are doing best fits to discover
OFFSET_X,OFFSET_Ybased on historical data, then this may be important.I think the simplest and cleanest test is:
Get
OBS_X,OBS_YandPTL_X,PTL_Yfrom the online DB. Here thePTLvalues were generated in the online system by applying the Constants DB transformation params toOBS.Use desimeter /
petal-alignments.yamlto do the analagous conversion intoPTL. (NoteOBS== what desimeter callsX_FP,Y_FP.)Check that
PTLvalues from (1) and (2) should exactly match.This comes out of a comment thread in https://github.com/desihub/desimeter/pull/98#issuecomment-646224141.