search

desihub / desimeter

DESI coordinates and transformations
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Use new version of the raytracing code #107

Closed julienguy closed 4 years ago

julienguy commented 4 years ago

Use updated ray-tracing code (DESI-4957-v18) based on as-built instrument (DESI-4037-v8). The main effect of a change of scale of 1.00084 due to a change in the curvature radius of the Mayall mirror. Once this scale is absorbed, the residual distortions with respect to the previous version are tiny (<0.01 arcsec). Thanks Mike Lampton, Paul Martini, Tim Miller for this update.

Comparison of the old vs new tan2fp transform before applying a scale correction: Figure_2_1

and after applying a scale correction of 1.00084 : Figure_2_2

(the differences are similar for other ADC angles)

julienguy commented 4 years ago

All codacy complaints are from RT185v2.py that I imported from DESI-4957 and I don't want to change it.