search

desihub / desimeter

DESI coordinates and transformations
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

xy2tp improve #112

Closed joesilber closed 4 years ago

joesilber commented 4 years ago

Added ability to provide a "guess" value for theta when converting from xy to tp. This allows the code to resolve the ambigous mirror image configurations of the kinematic arms. Previously we have always just used the case that puts phi within [0,180]. This is not a generally true fact, but can only be resolved when we have extra contextual knowledge. I tested the code both on cases I constructed in the unit test module, and on new arc data I measured for five positioners. I will put a description of this change together in a powerpoint soon and show it Friday or Monday, I expect.

joesilber commented 4 years ago

I can't fix the fucking codacy "trailing whitespace" errors. Git doesn't even recognize it as a change when I try to delete those characters. So screw it.

weaverba137 commented 4 years ago

If Codacy is prompting this level of frustration--which is being shared with the entire DESI collaboration--@sbailey, @julienguy, et al., please remind me again why this is necessary? In other desihub code, we do have style checks, but they are usually marked as allowed failures.

joesilber commented 4 years ago

Sorry for my f-bombs earlier! But yeah, it is kind of annoying. I also find that Codacy does not find actual syntax bugs in code (which my linter in Spyder does). So I'm not sure the point of Codacy, but oh well.