Analyze pos perf updates

desihub / desimeter

DESI coordinates and transformations

BSD 3-Clause "New" or "Revised" License

2 stars 4 forks source link

Analyze pos perf updates #123

Closed joesilber closed 3 years ago

joesilber commented 3 years ago

Major features:

histogram plots are now done independently, by quantile, at sigma = 1, 2, 3, 4, 5, inf
cleaner multiprocessing implementation

Minor:

circle envelopes plotted for each positioner on chart
clearer labeling of num targets vs num selected at various sigma levels
speed up file reads
replace slow rms calc
unused data columns (like PETAL_ID, BUS_ID, FLAGS, etc) now get passed through to output "moves" csv

julienguy commented 3 years ago

@joesilber I see you have some code related to logging . Note we have in desimeter the same logging set as in the rest of the data system code.

from desimeter.log import get_logger
log.info("bla")
log.debug("bla bla")
log.warning("woops")
log.error("argh")
log.critical("argh")

debug does not print anything unless you have set the env variable DESI_LOGLEVEL=DEBUG or you have done log.setLevel("DEBUG") before (which is not the expected usage, the expected usage is with the env. variable).

joesilber commented 3 years ago

@joesilber I see you have some code related to logging . Note we have in desimeter the same logging set as in the rest of the data system code.

Thanks @julienguy --- I will note this down as a future enhancement. I do need to make sure the desimeter logging is compatible with sending back messages from multiprocessing. But if so then I can use that.