search

desihub / desimeter

DESI coordinates and transformations
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Take into account proper motions #134

Closed segasai closed 4 years ago

segasai commented 4 years ago

Fixes #51

There were some white space auto-formatting changes in the first commit in the branch. I can undo those if needed.

julienguy commented 4 years ago

That's great but next time can you push your branch into this desimeter repo instead of doing a fork. I actually don't know how to checkout out your forked version to test it!

segasai commented 4 years ago

Hmm. I thought I followed the standard github practice of feature branch in a clone, followed by a PR. You can test my branch by cloning this https://github.com/segasai/desimeter.git (I haven't tested the code, as I didn't have a catalog at hand and nersc is down)

julienguy commented 4 years ago

That's what I am doing now. Please add a branch to this repo next time.

segasai commented 4 years ago

Okay, got it. I've forgot that I have developer rights here.

julienguy commented 4 years ago

It's not crashing because of missing columns. What I suggest is that I copy that part of the code into another branch (without the change of indentation) and with a test of Aaron's catalog that I have on disk. I'll ask you to review this one.

segasai commented 4 years ago

okay, it's fine by me.