Closed joesilber closed 3 years ago
It's not very convenient to use glob
to get the list of input files instead of the file system.
At nersc, the current implementation requires we run
merge_posparams -i '*_paramfits.csv' -o merged.csv
instead of
merge_posparams -i *_paramfits.csv -o merged.csv
It could be fixed by removing the call to glob and simply directly getting a list of filenames as an argument if one uses the extra nargs="*"
in the descriptor of the argument as it was in the previous version. But I guess you changed that to run on windows, so I let you see if there is another solution to find. I'm leaving the PR open for now.
Except for this detail it works fine.
Maybe add a sentence in prepare_posparams_for_instr --help
explaining what check_static_fit_bounds , check_xy_offsets, check_arm_lengths do. Are these tests against default values and metrology?
Suggestion to modify the handling of multiple files in the arguments to the get_posmoves script (see comment).
I put in a check for Windows, in which case use glob. Otherwsie revert to nargs='*' method.
main features
side stuff
example sequence