search

desihub / desimeter

DESI coordinates and transformations
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

missing attribute meandistance #162

Closed joesilber closed 3 years ago

joesilber commented 3 years ago

When running analyze_bright_image, I get the following error infvc2fp.py:

Traceback (most recent call last):
  File "/software/products/desimeter-master/bin/analyze_bright_image", line 62, in <module>
    print(transfo.tojson())
  File "/software/products/desimeter-master/py/desimeter/transform/fvc2fp.py", line 91, in tojson
    params['meandistance'] = self.meandistance
AttributeError: 'FVC2FP' object has no attribute 'meandistance'

Command to produce this is: analyze_bright_image --back-illuminated back1.fits --front-illuminated front1.fits -o pos1.csv

FITS files to run this example are at: front1.fits back1.fits

schlafly commented 3 years ago

Can you verify that https://github.com/desihub/desimeter/pull/163 addresses this? The new fvc2fp format had assumed that it would only be asked to read in files that it had created, which was a bad assumption.

schlafly commented 3 years ago

Addressed in https://github.com/desihub/desimeter/pull/163, closing.