Closed julienguy closed 3 years ago
Do you want a "code" review here or me to actually check the quality of the fits, etc.? My impression from your plots was that things looked as well as could be expected---though I don't have a good sense for what we expect the error in the rotation rate measurements to be.
Just having a rapid second look at the code to double check there is not some gross mistake. It's probably going in operation tomorrow evening, so it's better to have a second pair of eyes on it.
Looks good to me; I don't see any issues. Minor notes:
I leave the asymmetric HA terms in because I am not sure we have a strong reason to remove them and they are small. For reference, the analysis report associated to this PR is https://desi.lbl.gov/DocDB/cgi-bin/private/ShowDocument?docid=6032.
Updates to the empirical field rotation model based on new data saved in py/desimeter/data/guide_20201215_with_hexrot.csv.