search

desihub / desimeter

DESI coordinates and transformations
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Fiberassign #183

Closed julienguy closed 3 years ago

julienguy commented 3 years ago

Add functions to compute X,Y focal plane coordinates of fibers for fiber assignment. The transformations from RA,Dec to X,Y in CS5 or on the curved/flat coordinates and their inverse are in fiberassign.py.

There is a script bin/plot_pm_coords to run this and display residuals to platemaker coordinates. Ex:

plot_pm_coords -i /global/cfs/cdirs/desi/spectro/data/20210509/00087831/coordinates-00087831.fits

87831

coveralls commented 3 years ago

Coverage Status

Coverage increased (+1.3%) to 73.13% when pulling e0207f84679e5e511d3a1fd1b809d0acb7ce5362 on fiberassign into 45f2331e9b1a6f921e430c55dfde6520a741ca69 on master.

sbailey commented 3 years ago

I did some basic checks and this looks good to me. Thanks. I added a module-level docstring for context for our future selves.

sbailey commented 3 years ago

@dstndstn confirmed separately that this has what he needs, and it has already been used for test tile 81099, so merging and tagging post-facto.