desihub / desimeter

DESI coordinates and transformations
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

combine GEAR_CALIB_* with SCALE_* in posparams/fitter.py #66

Closed joesilber closed 4 years ago

joesilber commented 4 years ago

GEAR_CALIB_T and GEAR_CALIB_P are currently 1.0 in all cases on the Mayall. There may come a date at which robots have variable values set for these. This will affect the internally-tracked POS_T and POS_P angles (which is fine).

However, when running fit_posparams to deduce new values for SCALE_T and SCALE_P, the internally-tracked angles must be corrected for whatever GEAR_CALIB_* values were being used at the time the robot was commanded. Otherwise, the comparison of delta(commanded) vs delta(measured) will come out wrong.

Fix: 1.fitter.py --> Add additional arguments for vectors of GEAR_CALIB_T and GEAR_CALIB_P.

  1. In dynamic mode, pre-adjust the dt_int and dp_int data back to as if GEAR_CALIB_* == 1 at time of move.
  2. Then run the best-fit.
joesilber commented 4 years ago

closed in merge of pr #68