Set DESI_ROOT in desi_environment

weaverba137 commented 2 years ago

This PR prepares for Lmod on Perlmutter by moving the definition of DESI_ROOT into the desi_environment.(sh|csh) scripts. In addition "edison" is replaced with "permutter" and some environment variables are added to the main module for compatibility with 21.7e.

weaverba137 commented 2 years ago

PS, this should be merged in coordination with desihub/desitree#7.

weaverba137 commented 2 years ago

Pinging @sbailey for review.

weaverba137 commented 2 years ago

Update on perlmutter testing:

I created a bare-bones desiconda-like environment based on python/3.9-anaconda-2021.05.
desitree/0.6.0 does appear to work fine with ${DESI_ROOT} defined in desi_environment.sh.
Discovered a minor bug in desiutil that was patched directly on master.
Discovered that the NERSC-provided Python 3.9 environment on perlmutter is actually Python 3.8 (already reported to NERSC).
Haven't installed the full desimodules/master stack yet, because the main goal was to test desitree.
You can test by logging in to perlmutter and executing source /global/common/software/desi/perlmutter/desiconda/startup/modulefiles/desimodules/desi_environment.sh master.

desihub / desimodules

Set DESI_ROOT in desi_environment #33