search

desihub / desisim

DESI simulations
BSD 3-Clause "New" or "Revised" License
16 stars 22 forks source link

Fix incorrect BUNIT in frame and cframe fits headers in fast simulations. #316

Closed julienguy closed 6 years ago

julienguy commented 6 years ago

The BUNIT header keyword is wrong in frame and cframe fits headers in fast simulations. It does not impact flux calibration but it's an issue when computing scores on simulated frames.

julienguy commented 6 years ago

I checked that the BUNIT values are auto-consistent in the frame and cframe written by the fastframe code, I fixed that a few month ago. However we want fastframe to write photons/A instead of photons/bin as the extraction code. I am changing this now.

julienguy commented 6 years ago

fixed and merged in branch bunit