search

desihub / desisim

DESI simulations
BSD 3-Clause "New" or "Revised" License
16 stars 22 forks source link

Add dwave out to quickquasars #533

Closed alxogm closed 4 years ago

alxogm commented 4 years ago

Their PR is to allow quickquasars to produce mocks with pixels width specified by the user. This is related to the more general issue raised by Andreu https://github.com/desihub/desisim/issues/532.

Change is very simple, I've tested it in a small run here /global/cfs/projectdirs/desi/mocks/lya_forest/develop/london/qq_desi/v9.0/v9.0.0/desi-1.2-1.tmp/

I was waiting for some feedback from the DLA team, but I think it will be fine if we just go ahead.

**Other changes are only some missing spaces I added ...

alxogm commented 4 years ago

@andreufont I made a few more changes to handle the --bblux as default, previous syntax was not correct... I don't see when we will need it to set it as False but I better left the option anyway. I included an update of the warning message of a deprecated argument, just in case... I'll merge if there are no more changes. Thanks

alxogm commented 4 years ago

We decided to do a clean up of arguments in a separate PR. Then I'll merge once tests passes.

weaverba137 commented 3 years ago

Can the branch add_dwave_out be deleted?