quicktransients should catch failed template generation

desihub / desisim

DESI simulations

BSD 3-Clause "New" or "Revised" License

16 stars 22 forks source link

quicktransients should catch failed template generation #540

Closed sybenzvi closed 4 years ago

sybenzvi commented 4 years ago

The user-level script which generates galaxy + transient spectra through desisim and desitarget is letting through failed spectra (flux values all zero or containing NaN). The script could catch and skip these failures. It's possible this issue is duplicating #537.

sybenzvi commented 4 years ago

Fixed; see PR #541. Turns out this had nothing to do with bad templates or issue #537, but rather an incorrectly defined redshift array passed to sim_spectra. I know longer remember why I defined the array in the first place; February Segev made July Segev's life harder by not providing comments.