search

desihub / desisim

DESI simulations
BSD 3-Clause "New" or "Revised" License
16 stars 22 forks source link

add missing header keywords #551

Closed sbailey closed 3 years ago

sbailey commented 3 years ago

This PR adds some header keywords that were missing from simulated output. New template S/N ratio (TSNR) code in the spectro pipeline now requires these keywords, which was breaking the integration testing. Hardcoding the CCDSIZE is admittedly yucky, but I didn't see how to access that information from the params available to fastframe at that point in the code. I'm going to proceed with this so that I can proceed with integration testing, but if someone cares deeply enough they can separately contribute a cleaner solution later.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.0009%) to 45.357% when pulling 9ea1a6c8e9719b8e9274f04f21a2db709836b6f6 on simheaders into 06e3feda687677422eef5f39f33cdc4d61260908 on master.

sbailey commented 3 years ago

Failing test is suspiciously low LRG flux issue; proceeding without rerunning.