desihub / desisim

DESI simulations
BSD 3-Clause "New" or "Revised" License
16 stars 22 forks source link

Updated emission lines and continuum models #572

Closed HiramHerrera closed 1 year ago

HiramHerrera commented 1 year ago

The following Pull Request updates:

LyA Region LyB region
image image

This new model also addresses the correlation between CIV Equivalent Width and Magnitude as found on observational data. Previous mocks didn't have such correlation

image
andreufont commented 1 year ago

Happy to merge once Alma is happy, she know more than I do about this part of the code.

I wouldn't worry too much about the "mean continuum" plot above, since the data has redshift errors that are not present in the mocks (are they?), and as we saw in Youles et al. (2022) this has an effect in the mean continuum measured by Picca.

alxogm commented 1 year ago

I think you can merge @HiramHerrera