template_dir to template_path for redrock templates

desihub / desispec

DESI spectral pipeline

BSD 3-Clause "New" or "Revised" License

35 stars 24 forks source link

template_dir to template_path for redrock templates #2168

Closed akremin closed 7 months ago

akremin commented 7 months ago

Redrock made a non-backward-compatible change to a function parameter name that broke the MgII afterburner as outlined in issue #2167 .

This fixes it by updating the afterburner to use the new variable name "template_path" rather than the old "template_dir".

I have tested this by linking over an exposure directory from last night and running off of main to reproduce the error, then running out of this branch, which succeeded.

I'm self-merging so we can use this for daily operations.

moustakas commented 7 months ago

Thanks @akremin, this was precisely the change I made locally. BTW, I noticed that the branch didn't get deleted, so I'm deleting it now.