Closed sbailey closed 6 months ago
Note, desispec.io.fibermap.fibermap_columns
is not actually intended to be used 'out of the box', but only after desispec.io.fibermap._set_fibermap_columns()
is run. That fills in the other surveys. I don't know if there's a better way of doing that.
Confirming that this will be closed by #2176.
This didn't get automatically closed by #2176, closing.
desispec.io.write_spectra attempts to add comment fields to the output fibermap using desispec.io.fibermap.fibermap_comments. However, the structure of fibermap_comments has changed which silently broke adding comments (or perhaps it was never right in the first place, I haven't dug into the history).
I think the new structure is
whereas write_spectra throught it was just
fibermap_comments[colname] = comment
.Currently only survey='main' exists, and unfortunately the spectra don't propagate SURVEY (yet, see #2170), but it would be reasonable to default to 'main' if write_spectra gets a Spectra object without SURVEY specified.