search

desihub / desispec

DESI spectral pipeline
BSD 3-Clause "New" or "Revised" License
33 stars 24 forks source link

Make nightqa dark sel robust to new ccdcalib #2206

Closed akremin closed 3 months ago

akremin commented 3 months ago

Quick fix to issue #2204 . ccdcalib now lists flats used for cte corrections, if performed, which broke the qa code looking for the dark exposure. This fixes it by taking the first exposure if multiple are present, which is the dark exposure based on the pipeline logic. We could do additional sanity checks to make sure it is a dark expid, but this is programmatically how the pipeline currently works. If it breaks in the future then I suggest we do a more rigorous and in-depth patch.

@anand please check to see if you're happy with this intellectually. Then we're safe to merge and rerun nightqa for last night.

araichoor commented 3 months ago

looks good to me, thanks! minor comment: would it be worth it to add a comment describing that logic just before the "if"?

akremin commented 3 months ago

Thanks for the check and suggestion. I've added a comment to explain what the string manipulation is doing. I'll self merge.