search

desihub / desispec

DESI spectral pipeline
BSD 3-Clause "New" or "Revised" License
33 stars 24 forks source link

Add 5 missing columns to the fibermap #2219

Closed geordie666 closed 2 months ago

geordie666 commented 2 months ago

This PR adds 5 missing columns to the fibermap (MEAN_MJD, MIN_MJD, MAX_MJD, FIRSTNIGHT, LASTNIGHT).

It addresses #2218.

geordie666 commented 2 months ago

Example output file:

/pscratch/sd/a/adamyers/blat-with-units.fits

Check the new code works after running, e.g.:

rrdesi -i /global/cfs/cdirs/desi/spectro/redux/daily/tiles/cumulative/3351/20230905/coadd-0-3351-thru20230905.fits --outfile $SCRATCH/blat.fits --ntargets 5


fitsio.read_header("/pscratch/sd/a/adamyers/blat-with-units.fits", "FIBERMAP")

TTYPE73 = 'MEAN_MJD'           / Mean MJD across fibers contributing to coadd
TFORM73 = 'D'                  / 
TUNIT73 = 'd'                  / MEAN_MJD units
...
TTYPE80 = 'MIN_MJD'            / Minimum MJD contributing to fiber coadd
TFORM80 = 'D'                  / 
TUNIT80 = 'd'                  / MIN_MJD units
TTYPE81 = 'MAX_MJD'            / Maximum MJD contributing to fiber coadd
TFORM81 = 'D'                  / 
TUNIT81 = 'd'                  / MAX_MJD units
TTYPE82 = 'FIRSTNIGHT'         / First night tile was observed (YYYYMMDD)
TFORM82 = 'J'                  / 
TTYPE83 = 'LASTNIGHT'          / Last night tile was observed (YYYYMMDD)
TFORM83 = 'J'                  /
geordie666 commented 2 months ago

I'll now also add those columns to desidatamodel.