desihub / desispec

DESI spectral pipeline
BSD 3-Clause "New" or "Revised" License
33 stars 24 forks source link

fix multi-badamp parsing #2233

Closed sbailey closed 2 months ago

sbailey commented 2 months ago

This PR fixes a bug in BADAMP header keyword parsing when multiple amps are bad. The keyword is just the characters without commas, e.g. "AC" not "A,C". This PR updates to support either case in the future though.

Previously fails, now works:

desi_compute_psf --input-image /dvs_ro/cfs/cdirs/desi/spectro/redux/j1/preproc/20231204/00207924/preproc-b5-00207924.fits.gz --input-psf /dvs_ro/cfs/cdirs/desi/spectro/redux/j1/exposures/20231204/00207924/shifted-input-psf-b5-00207924.fits --output-psf $SCRATCH/fit-psf-b5-00207924.fits --broken-fibers 342,400

I will self merge once tests pass so that we can update and run with this for pre-Jura testing.