Closed sbailey closed 2 months ago
@akremin please also update to move nightlyflat jobs to GPU nodes, and then merge when ready. Let's test this on j1 while we still have the juratest2_cpu and juratest2_gpu reservations (EDITED to correct reservation names)
This PR adds support for specifying separate reservation names for CPU and GPU reservations, with either of them optionally being None, e.g. if we had a CPU reservation but not a GPU reservation.
Examples in $CFS/desi/users/sjbailey/spectro/redux/j1
grep for "sbatch" in each of those log files:
--reservation=blat
--reservation=blat_cpu
or--reservation=foo_gpu
depending upon their job type--reservation=blat_cpu
, but GPU jobs don't have any --reservation specified.This also works for desi_resubmit_queue_failures since that uses the same
submit_batch_script
function. Yay! I tested this with the ongoing j1 production:--> The 4 ztile jobs to resubmit had
--reservation=foo_gpu
Implementation note: I opted to not enforce _cpu/_gpu endings to reservation names, which gives us more flexibility for reservation names in the future and makes it easier to support having a reservation for one but not the other.
@akremin please check